vcard: Fix whitespace handling in line cont's - #9637
Merged
alecpl merged 3 commits intoSep 18, 2024
Conversation
Previously, multiple whitespace characters at the start of a continuation line would all be dropped, instead of only the first one. Also, - restrict line continuation characters to SPACE and TAB. Note that, like before, this identifies the CR (`\r`) character with the empty string, and thereby notably does not require a CRLF (`\r\n`) sequence (which is mandated by RFCs 2426, 2425) for line termination (i.e., `\n` suffices). Fixes: Bug 1 of issue roundcube#9593.
Member
|
Thank you very much! The failing tests are unrelated to your changes, I guess. I'll try to run them again later, since it looks like a temporary problem. If you feel up to it I'd really celebrate if you would add a unit-test to check the now correct behaviour! |
Member
|
@alecpl The CI fails because the TLS-cert of git.kolab.org expired 2 days ago. Is there maybe anything you can do about that? |
Contributor
Author
|
Test added. Running the tests locally, I got the following, seemingly unrelated failure: |
Member
|
That sorting failure is unrelated, don't worry about it! |
Member
|
Have a look at the Coding Style check errors, please. |
Contributor
Author
|
Fixed coding style errors. |
pabzm
approved these changes
Sep 18, 2024
pabzm
left a comment
pabzm
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thank you very much for your contribution!
alecpl
pushed a commit
that referenced
this pull request
Sep 18, 2024
* vcard: Fix whitespace handling in line cont's Previously, multiple whitespace characters at the start of a continuation line would all be dropped, instead of only the first one. Also, - restrict line continuation characters to SPACE and TAB. Note that, like before, this identifies the CR (`\r`) character with the empty string, and thereby notably does not require a CRLF (`\r\n`) sequence (which is mandated by RFCs 2426, 2425) for line termination (i.e., `\n` suffices). Fixes: Bug 1 of issue #9593. * vcard: Add test for #9593/1 * Fix coding style
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, multiple whitespace characters at the start of a continuation line would all be dropped, instead of only the first one.
Also,
Note that, like before, this identifies the CR (
\r) character with the empty string, and thereby notably does not require a CRLF (\r\n) sequence (which is mandated by RFCs 2426, 2425) for line termination (i.e.,\nsuffices).Fixes: Bug 1 of issue #9593.