Re-apply #829: Add ParameterEventsSubscriber class#1573
Merged
Conversation
Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
…m from event Signed-off-by: bpwilcox <[email protected]>
… parameter, address feedback Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]> use const string & for node name Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
…_parameter_update, mutex for thread-safety Signed-off-by: bpwilcox <[email protected]>
functions to remove parameter callbacks add functions to remove event callbacks, remove subscriptions, allow subscribing event callback to many namespaces, additional test coverage Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: bpwilcox <[email protected]>
… source Signed-off-by: bpwilcox <[email protected]>
…ight, add get_node_logging_interface, modify constructor Signed-off-by: bpwilcox <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Address code review feedback
…Monitor Signed-off-by: Michael Jeronimo <[email protected]>
Another name change; using Handler instead of the more passive term, …
Per William's review feedback. Signed-off-by: Michael Jeronimo <[email protected]>
Pass SharedPtrs callback remove functions instead of bare pointers
Signed-off-by: Michael Jeronimo <[email protected]>
* Remove unused interfaces * Document LIFO order for invoking callbacks * Add test cases to verify LIFO order for callbacks Signed-off-by: Michael Jeronimo <[email protected]>
Address review feedback
Signed-off-by: Michael Jeronimo <[email protected]>
A couple more doc fixes from review comments
|
Signed-off-by: Michael Jeronimo <[email protected]>
|
Signed-off-by: Michael Jeronimo <[email protected]>
|
Restart MacOS build after removing an unused parameter warning. |
delete-merged-branch
Bot
deleted the
re-apply-829/add_parameter_event_subscriber
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-application of #829 which was merged but then reverted in #1572 due to issues building on Windows.