[foxy] node_handle must be destroyed after client_handle to prevent memory leak (#1562)#1565
Merged
fujitatomoya merged 1 commit intoros2:foxyfrom Feb 27, 2021
Conversation
…eak (ros2#1562) Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
force-pushed
the
foxy-bugfix-20210225-memory-leak-1545
branch
from
874d4fb to
8ba0b42
Compare
Collaborator
Author
|
re-ordering member variables can break ABI, should I close this? |
Member
This seems to be using the PIMPL pattern, so it shouldn't be a problem |
Collaborator
Author
|
@ivanpauno thanks for checking. i am starting CI before merge. CI:
|
Collaborator
Author
|
windows build failure cz of chocolatey_package 'cppcheck' installation. i do not think that is related to the fix. |
Collaborator
Author
|
@ivanpauno @jacobperron thanks for checking 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foxy backport for #1562, address #1545.
Signed-off-by: Tomoya.Fujita [email protected]