node_handle must be destroyed after client_handle to prevent memory leak (#1562) (#1565)

fujitatomoya · web-flow · commit 47f21dab3d2c · 2021-02-28T00:03:32.000+09:00
Signed-off-by: Tomoya Fujita &lt;Tomoya.Fujita@sony.com&gt;
diff --git a/rclcpp_action/src/client.cpp b/rclcpp_action/src/client.cpp
@@ -100,8 +100,9 @@ class ClientBaseImpl
 
   rclcpp::Context::SharedPtr context_;
   rclcpp::node_interfaces::NodeGraphInterface::WeakPtr node_graph_;
-  std::shared_ptr<rcl_action_client_t> client_handle{nullptr};
+  // node_handle must be destroyed after client_handle to prevent memory leak
   std::shared_ptr<rcl_node_t> node_handle{nullptr};
+  std::shared_ptr<rcl_action_client_t> client_handle{nullptr};
   rclcpp::Logger logger;
 
   using ResponseCallback = std::function<void (std::shared_ptr<void> response)>;
