Add empty set_atomically parameter service#354
Merged
JanStaschulat merged 2 commits intomasterfrom Jun 12, 2023
Merged
Conversation
Signed-off-by: acuadros95 <[email protected]>
Signed-off-by: acuadros95 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 69.20% 69.63% +0.42%
==========================================
Files 16 16
Lines 2715 2760 +45
Branches 765 766 +1
==========================================
+ Hits 1879 1922 +43
- Misses 450 452 +2
Partials 386 386
|
fujitatomoya
approved these changes
Jun 8, 2023
|
If it's at all helpful I've checkout out and built this branch and it fixes the ros2cli issues for me. |
JanStaschulat
approved these changes
Jun 12, 2023
Contributor
|
@Mergifyio backport rolling iron |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Add empty set_atomically parameter service Signed-off-by: acuadros95 <[email protected]> * Fix cpplint Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> (cherry picked from commit 688bd28)
mergify Bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Add empty set_atomically parameter service Signed-off-by: acuadros95 <[email protected]> * Fix cpplint Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> (cherry picked from commit 688bd28)
Contributor
|
@Acuadros95 I added a backport for rolling and iron distribution. Do you want/need this fix on Humble and Foxy distribution as well? |
Collaborator
Author
|
@JanStaschulat No, this is just needed on Iron and Rolling. Thanks! |
JanStaschulat
added a commit
that referenced
this pull request
Jun 14, 2023
* Add empty set_atomically parameter service (#354) * Add empty set_atomically parameter service Signed-off-by: acuadros95 <[email protected]> * Fix cpplint Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> (cherry picked from commit 688bd28) * trigger CI-pipeline Signed-off-by: Jan Staschulat <[email protected]> * Uncrustify Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: acuadros95 <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]> Co-authored-by: Jan Staschulat <[email protected]> Co-authored-by: acuadros95 <[email protected]>
JanStaschulat
added a commit
that referenced
this pull request
Jun 14, 2023
* Add empty set_atomically parameter service (#354) * Add empty set_atomically parameter service Signed-off-by: acuadros95 <[email protected]> * Fix cpplint Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> (cherry picked from commit 688bd28) * Trigger ci-pipeline again. Signed-off-by: Jan Staschulat <[email protected]> * Fix uncrustify Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: acuadros95 <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]> Co-authored-by: Jan Staschulat <[email protected]> Co-authored-by: acuadros95 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New parameter client implementations check the availability of all the related services before executing a command.
We were missing the
/set_parameters_atomically, making ROS 2 Cli parameter commands fail.This PR adds a empty service implementation to fix this issue. Related: micro-ROS/micro-ROS-Agent#195
Note: This fix shall be included on the Iron release.