Fix parameter change event#310
Merged
Acuadros95 merged 1 commit intohumblefrom Aug 23, 2022
Merged
Conversation
Signed-off-by: acuadros95 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## humble #310 +/- ##
=======================================
Coverage 69.13% 69.13%
=======================================
Files 16 16
Lines 2715 2715
Branches 765 765
=======================================
Hits 1877 1877
Misses 451 451
Partials 387 387
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pablogs9
approved these changes
Aug 22, 2022
Member
pablogs9
left a comment
pablogs9
left a comment
There was a problem hiding this comment.
LGTM, can you take a look @JanStaschulat?
Member
|
Please backport to Rolling |
Collaborator
Author
|
@mergify backport master |
mergify Bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
Signed-off-by: acuadros95 <[email protected]> Signed-off-by: acuadros95 <[email protected]> (cherry picked from commit 786d95e)
Contributor
✅ Backports have been createdDetails
|
pablogs9
pushed a commit
that referenced
this pull request
Oct 4, 2022
Signed-off-by: acuadros95 <[email protected]> Signed-off-by: acuadros95 <[email protected]> (cherry picked from commit 786d95e) Co-authored-by: Antonio Cuadros <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: acuadros95 [email protected]
Quick fix for parameter modifications notification:
rclc_parameter_prepare_changed_evenis called.