Fix parameter change event (#310)

Acuadros95 · mergify[bot] · commit 9b39b7ddcecc · 2022-08-23T07:12:21.000Z
Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: acuadros95 <acuadros1995@gmail.com> (cherry picked from commit 786d95e)
diff --git a/rclc_parameter/src/rclc_parameter/parameter_server.c b/rclc_parameter/src/rclc_parameter/parameter_server.c
@@ -1300,13 +1300,13 @@ rclc_parameter_set_bool(
     return RCLC_PARAMETER_MODIFICATION_REJECTED;
   }
 
+  parameter->value.bool_value = value;
+
   if (parameter_server->notify_changed_over_dds) {
     rclc_parameter_prepare_changed_event(&parameter_server->event_list, parameter);
     rclc_parameter_service_publish_event(parameter_server);
   }
 
-  parameter->value.bool_value = value;
-
   return RCL_RET_OK;
 }
 
@@ -1345,13 +1345,13 @@ rclc_parameter_set_int(
     return RCLC_PARAMETER_MODIFICATION_REJECTED;
   }
 
+  parameter->value.integer_value = value;
+
   if (parameter_server->notify_changed_over_dds) {
     rclc_parameter_prepare_changed_event(&parameter_server->event_list, parameter);
     rclc_parameter_service_publish_event(parameter_server);
   }
 
-  parameter->value.integer_value = value;
-
   return RCL_RET_OK;
 }
 
@@ -1390,13 +1390,13 @@ rclc_parameter_set_double(
     return RCLC_PARAMETER_MODIFICATION_REJECTED;
   }
 
+  parameter->value.double_value = value;
+
   if (parameter_server->notify_changed_over_dds) {
     rclc_parameter_prepare_changed_event(&parameter_server->event_list, parameter);
     rclc_parameter_service_publish_event(parameter_server);
   }
 
-  parameter->value.double_value = value;
-
   return RCL_RET_OK;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1300,13 +1300,13 @@ rclc_parameter_set_bool(`
`1300`	`1300`	`return RCLC_PARAMETER_MODIFICATION_REJECTED;`
`1301`	`1301`	`}`
`1302`	`1302`
	`1303`	`+ parameter->value.bool_value = value;`
	`1304`	`+`
`1303`	`1305`	`if (parameter_server->notify_changed_over_dds) {`
`1304`	`1306`	`rclc_parameter_prepare_changed_event(&parameter_server->event_list, parameter);`
`1305`	`1307`	`rclc_parameter_service_publish_event(parameter_server);`
`1306`	`1308`	`}`
`1307`	`1309`
`1308`		`- parameter->value.bool_value = value;`
`1309`		`-`
`1310`	`1310`	`return RCL_RET_OK;`
`1311`	`1311`	`}`
`1312`	`1312`
`@@ -1345,13 +1345,13 @@ rclc_parameter_set_int(`
`1345`	`1345`	`return RCLC_PARAMETER_MODIFICATION_REJECTED;`
`1346`	`1346`	`}`
`1347`	`1347`
	`1348`	`+ parameter->value.integer_value = value;`
	`1349`	`+`
`1348`	`1350`	`if (parameter_server->notify_changed_over_dds) {`
`1349`	`1351`	`rclc_parameter_prepare_changed_event(&parameter_server->event_list, parameter);`
`1350`	`1352`	`rclc_parameter_service_publish_event(parameter_server);`
`1351`	`1353`	`}`
`1352`	`1354`
`1353`		`- parameter->value.integer_value = value;`
`1354`		`-`
`1355`	`1355`	`return RCL_RET_OK;`
`1356`	`1356`	`}`
`1357`	`1357`
`@@ -1390,13 +1390,13 @@ rclc_parameter_set_double(`
`1390`	`1390`	`return RCLC_PARAMETER_MODIFICATION_REJECTED;`
`1391`	`1391`	`}`
`1392`	`1392`
	`1393`	`+ parameter->value.double_value = value;`
	`1394`	`+`
`1393`	`1395`	`if (parameter_server->notify_changed_over_dds) {`
`1394`	`1396`	`rclc_parameter_prepare_changed_event(&parameter_server->event_list, parameter);`
`1395`	`1397`	`rclc_parameter_service_publish_event(parameter_server);`
`1396`	`1398`	`}`
`1397`	`1399`
`1398`		`- parameter->value.double_value = value;`
`1399`		`-`
`1400`	`1400`	`return RCL_RET_OK;`
`1401`	`1401`	`}`
`1402`	`1402`