Skip to content

Prevent log spam from tf2_ros message_filter (backport #851)#853

Merged
ahcorde merged 3 commits intojazzyfrom
mergify/bp/jazzy/pr-851
Nov 24, 2025
Merged

Prevent log spam from tf2_ros message_filter (backport #851)#853
ahcorde merged 3 commits intojazzyfrom
mergify/bp/jazzy/pr-851

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 20, 2025

Description

Fixes ros2/rviz#513

Is this user-facing behavior change?

Yes, the logs will appear less frequently

Did you use Generative AI?

No

Additional Information

Related to ros-navigation/navigation2#5163, before the initial_pose is set, without this change, the terminal will be flooded with log like:

[rviz2-9] [INFO 1763554575.338340800] [rviz]: Message Filter dropping message: frame 'odom' at time 54.105 for reason 'discarding message because the queue is full' (signalFailure() at /root/nav2_ws/src/geometry2/tf2_ros/include/tf2_ros/message_filter.hpp:771)
[rviz2-9] [INFO 1763554575.400898439] [rviz]: Message Filter dropping message: frame 'rplidar_link' at time 59.502 for reason 'discarding message because the queue is full' (signalFailure() at /root/nav2_ws/src/geometry2/tf2_ros/include/tf2_ros/message_filter.hpp:771)

cc @SteveMacenski

This is an automatic backport of pull request #851 done by Mergify.

@mini-1235 @mergify
Prevent log spam from tf2_ros message_filter (#851)
1d9a86a 
Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)

# Conflicts:
#	tf2_ros/include/tf2_ros/message_filter.hpp
@mergify mergify Bot added the conflicts label Nov 20, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Nov 20, 2025

Cherry-pick of 00ea530 has failed:

On branch mergify/bp/jazzy/pr-851
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 00ea530.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tf2_ros/include/tf2_ros/message_filter.hpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot mentioned this pull request Nov 20, 2025
Merged
@ahcorde
fixed merge
f5392d5 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Fixed merge
e214a2c 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 20, 2025 •
edited
Loading

Pulls: #853
Gist: https://gist.githubusercontent.com/ahcorde/9e221459c49bd98b1370434fae5c4746/raw/d07593cb60309fb67adf15ecc58dd353117bb8d7/ros2.repos
BUILD args: --packages-above-and-dependencies tf2_ros
TEST args: --packages-above tf2_ros
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17557

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit d011823 into jazzy Nov 24, 2025
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-851 branch November 24, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahcorde @mini-1235