Changing BT loading warning to be more clear#5938
Merged
SteveMacenski merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
Signed-off-by: SteveMacenski <[email protected]>
Comment out the ros2/rviz repository entry in underlay.repos Signed-off-by: Steve Macenski <[email protected]>
Contributor
|
This pull request is in conflict. Could you fix it @SteveMacenski? |
Signed-off-by: Steve Macenski <[email protected]>
Codecov Report❌ Patch coverage is
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mini-1235
added a commit
to mini-1235/navigation2
that referenced
this pull request
Feb 11, 2026
…5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]>
8 tasks
SteveMacenski
pushed a commit
that referenced
this pull request
Feb 20, 2026
* Revert "Changing BT loading warning to be more clear (#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
* Changing BT loading warning to be more clear Signed-off-by: SteveMacenski <[email protected]> * Comment out ros2/rviz repository Comment out the ros2/rviz repository entry in underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: SteveMacenski <[email protected]> Signed-off-by: Steve Macenski <[email protected]>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 22, 2026
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 22, 2026
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]> Signed-off-by: Maurice <[email protected]>
EricoMeger
pushed a commit
to EricoMeger/navigation2
that referenced
this pull request
Feb 22, 2026
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #5924