Bt warning fix#5594
Conversation
2be7daf to
c48f8ee
Compare
Codecov Report❌ Patch coverage is
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
left a comment
There was a problem hiding this comment.
Pull in main / rebase in order for CI to pass
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
…_impl.hpp Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
ef5192b to
4a62ece
Compare
…_impl.hpp Signed-off-by: Steve Macenski <[email protected]>
…_impl.hpp Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Jad El Hajj <[email protected]>
yes, we wont get the btcpp warning anymore :) |
Please cover these lines (these ones should be easy) for CI and I can merge, thanks! |
Signed-off-by: Jad El Hajj <[email protected]>
All use cases are now covered :-) |
|
@Jad-ELHAJJ please check out https://app.codecov.io/gh/ros-navigation/navigation2/pull/5594 there are lots of gaps still that this didn't cover. They mostly seems easy to solve with unit tests
|
Check
|
* fix the loadbehaviortree impl and its test Signed-off-by: Jad El Hajj <[email protected]> * pr refactoring and added tests Signed-off-by: Jad El Hajj <[email protected]> * simplify logic Signed-off-by: Jad El Hajj <[email protected]> * simplify loadbehaviortree Signed-off-by: Jad El Hajj <[email protected]> * unused Signed-off-by: Jad El Hajj <[email protected]> * removed st bb Signed-off-by: Jad El Hajj <[email protected]> * PR fix Signed-off-by: Jad El Hajj <[email protected]> * readd old code Signed-off-by: Jad El Hajj <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp Signed-off-by: Steve Macenski <[email protected]> * added try catch and comments Signed-off-by: Jad El Hajj <[email protected]> * lint Signed-off-by: Jad El Hajj <[email protected]> * PR fix Signed-off-by: Jad El Hajj <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp Signed-off-by: Steve Macenski <[email protected]> * Fix indentation Signed-off-by: Jad El Hajj <[email protected]> * Added test Signed-off-by: Jad El Hajj <[email protected]> --------- Signed-off-by: Jad El Hajj <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
* fix the loadbehaviortree impl and its test Signed-off-by: Jad El Hajj <[email protected]> * pr refactoring and added tests Signed-off-by: Jad El Hajj <[email protected]> * simplify logic Signed-off-by: Jad El Hajj <[email protected]> * simplify loadbehaviortree Signed-off-by: Jad El Hajj <[email protected]> * unused Signed-off-by: Jad El Hajj <[email protected]> * removed st bb Signed-off-by: Jad El Hajj <[email protected]> * PR fix Signed-off-by: Jad El Hajj <[email protected]> * readd old code Signed-off-by: Jad El Hajj <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp Signed-off-by: Steve Macenski <[email protected]> * added try catch and comments Signed-off-by: Jad El Hajj <[email protected]> * lint Signed-off-by: Jad El Hajj <[email protected]> * PR fix Signed-off-by: Jad El Hajj <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp Signed-off-by: Steve Macenski <[email protected]> * Fix indentation Signed-off-by: Jad El Hajj <[email protected]> * Added test Signed-off-by: Jad El Hajj <[email protected]> --------- Signed-off-by: Jad El Hajj <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Decwest <[email protected]>
This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]>
This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]>
* Revert "Changing BT loading warning to be more clear (#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]>
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]>
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]>
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]>
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]>
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]> Signed-off-by: panav <[email protected]> Signed-off-by: Maurice <[email protected]>
…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <[email protected]> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <[email protected]> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <[email protected]> * Revert unrelated changes Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Second prototype Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Apply suggestions Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Only require main id when using filepath Signed-off-by: mini-1235 <[email protected]> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Fix test Signed-off-by: mini-1235 <[email protected]> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <[email protected]> * Add test to cover corner case Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice Alexander Purnawan <[email protected]>
Basic Info
Description of contribution in a few bullet points
A fix PR making sure that BTCPP warning would never be logged. The final logic will be:
Description of how this change was tested
PS: codecov might complain about not covered code in
bt_action_server_impl.hpp, but I added unit test for all 4 conditions. So the mock loadBehaviorTree intest_behavior_tree_node.cppwill be covering the new changes.For Maintainers:
backport-*.