[Collision Monitor] Add a watchdog mechanism#3880
Merged
SteveMacenski merged 15 commits intoros-navigation:mainfrom Oct 31, 2023
Merged
[Collision Monitor] Add a watchdog mechanism#3880SteveMacenski merged 15 commits intoros-navigation:mainfrom
SteveMacenski merged 15 commits intoros-navigation:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Submitting as a draft as there are a couple of points to discuss.
This PR adds a per source blocking watchdog mechanism, i.e. stop the robot if a source is not publishing at the expected rate (building on the existing
source_timeoutmechanism).block_if_invalid(other name suggestions are welcome) either per source or globally. If set totrue, a source triggering itssource_timeoutwill make the robot stop.source_timeoutper source. I.e. having different value for each sensors. In order not break the current behavior, if not set, each source specificsource_timeoutare set by default to the globalsource_timeout.getDatamethod to returnfalseif a source is considered invalid ANDblock_if_invalid: true. @AlexeyMerzlyakov, can you maybe check/have a look if the invalid conditions make sense ?block_if_invalid?Description of documentation updates required from your changes
TBD once points above are resolved
Future work that may be required in bullet points
For Maintainers: