Rewrite the scan topic costmap plugins for multi-robot(namespace) before launch navigation.#3572
Merged
SteveMacenski merged 4 commits intoros-navigation:mainfrom Aug 18, 2023
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This changes make it more convinient to manage nav2_params.yaml file for multi-robot environment and easy to launch the navigation.
According to latest guideline, each robot requires different nav2_param files since absoulte path of topic ifor scan is required in local_costmap/global_costmap node.
if we set the topic name without slash'/' like 'scan', rclpp node will add prefix automatically for example ,
local_costmap/local_costmap/scan. So we should specify absoulute path such as/scanor/namespace/scanBut, the code I suggested will rewrite the value for the key 'topic:'.
As far as I know, 'topic' key is only used for costmap plugins
I think this changes quite make sense. :)
Description of documentation updates required from your changes
For multi-robot launch, it should be launched with namespace leading prefix '/'.
This shall try to subscribe
local_costmap/local_costmap/acloi00/scan.So the guideline for mutli-robot bringup should be noticed.
Future work that may be required in bullet points
First time when I faced this inconvenient environemnt, I'd like to describe the 'param_rewirtes' like this.
{'local_costmap.local_costmap.ros__parameters.*.*.topic': (namespace,'/scan')}I tried to modify RewrittenYaml() class what I thougt and expected but gave up :) because I''m not familiar with this class.
For Maintainers: