Patch for PhotoAtWaypoint plugin. #2066
Closed
jediofgever wants to merge 10 commits intoros-navigation:mainfrom
jediofgever:main
Closed
Patch for PhotoAtWaypoint plugin. #2066jediofgever wants to merge 10 commits intoros-navigation:mainfrom jediofgever:main
jediofgever wants to merge 10 commits intoros-navigation:mainfrom
jediofgever:main
Conversation
Signed-off-by: jediofgever <[email protected]>
Signed-off-by: jediofgever <[email protected]>
Signed-off-by: jediofgever <[email protected]>
Signed-off-by: jediofgever <[email protected]>
Signed-off-by: jediofgever <[email protected]>
…rectory for photo at waypoint plugin Signed-off-by: jediofgever <[email protected]>
SteveMacenski
requested changes
Oct 30, 2020
| } | ||
| } | ||
| } catch (const std::exception & e) { | ||
| std::cerr << e.what() << '\n'; |
Member
There was a problem hiding this comment.
Use proper logging please
Member
There was a problem hiding this comment.
Also if an exception was thrown, is_enabled_ should be false
Contributor
Author
There was a problem hiding this comment.
Hmm unfortunately I have no longer access to my laptop after today(for an indefinite time). Could you take care of this for me please ?
Thank you
Member
|
@jediofgever done, I need to open a new PR to merge in those changes since it was on your private fork |
Member
|
See #2067 |
Contributor
Author
|
@SteveMacenski , thanks a lot , had some issues with my PC and sent it to service. |
Member
|
Please review #2067 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2041 Introduced PhotoAtWaypoint plugin.
A directory path should be given to plugin for saving the photos. If the given directory does not exist we create one with
std::experimental::filesystem,but this may throw exceptions if the given path is an invalid one. So a try catch block should surround that part of the code where we try to create directory.This PR has that.