How did you test this?

I'd like to make sure this does all of the following:

• Using the Navigation2 "Go to pose" button, which under the hood calls the action server
• Using the RVIZ default "go to pose" button, which under the hood uses the topic, which covers the /goal_pose topic working.

You're, at a minimum, missing the navigate_to_pose_action.cpp call.

Make sure the following is no longer true:

mkhansen@mkhansen-desk:~/ros2_dev/navigation2_ws$ ros2 action info /NavigateToPose
Action: /NavigateToPose
Action clients: 0
Action servers: 1
    /bt_navigator
mkhansen@mkhansen-desk:~/ros2_dev/navigation2_ws$ ros2 action info /navigate_to_pose
Action: /navigate_to_pose
Action clients: 1
    /bt_navigator_client_node
Action servers: 0

How did you test this?

In no comprehensive way, really. I don't have a robot at hand to test, and nav2 tests failed for me locally in a variety of different ways each time I attempted to move forward with this (not a lot of time to invest though). I'll try once again next week, probably clone everything from scratch and use the Dockerfile in the repo (I have my own containers for general ROS2 development, but to no avail).

I'll ping you back when that comes along.

You're, at a minimum, missing the navigate_to_pose_action.cpp call.

Interesting. I thought I had made sure to change the action name but not the behavior name. Something else's missing clearly.

Did you try it in simulation?

Did you try it in simulation?

What is the preferred simulation environment for Nav2 testing?

Here is one option: https://ros-planning.github.io/navigation2/howtos/tutorials/docs/navigation2_with_turtlebot3_in_gazebo.html

Any movement here?

Also please rebase off master, I pushed a bunch of updates to fix CI.

It was tested by @ZakariaChekakta to work, @hidmic can you rebase to master so we can run CI and merge?

@SteveMacenski my apologies for the delay, it's been a busy time. Will do and thank you @ZakariaChekakta!

Codecov Report

Merging #1484 into master will increase coverage by 0.06%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   37.26%   37.33%   +0.06%     
==========================================
  Files         227      227              
  Lines       11869    11869              
  Branches     5145     5145              
==========================================
+ Hits         4423     4431       +8     
+ Misses       4038     4026      -12     
- Partials     3408     3412       +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4349f...389c2f3. Read the comment docs.

mhm, there seems to be something wrong. All the integration tests are failing. I just reran, maybe just a fluke.

Last failure is upstream in rclcpp, merging