Use NavigateToPose action name everywhere.#1467
Merged
mkhansenbot merged 1 commit intoros-navigation:eloquent-develfrom Jan 15, 2020
Merged
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
SteveMacenski
approved these changes
Jan 15, 2020
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Is it your plan to submit a PR for snake_casing in master?
Author
|
@SteveMacenski yes, will do tomorrow, I didn't get to re run all tests locally for that patch. |
mkhansenbot
approved these changes
Jan 15, 2020
Collaborator
mkhansenbot
left a comment
mkhansenbot
left a comment
There was a problem hiding this comment.
Thanks for fixing this and re-submitting to eloquent-devel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Primary OS tested onRobotic platform tested onNote: I don't have a platform at hand to test and system tests are failing for me, even on plain
eloquent-devel.Description of contribution in a few bullet points
NavigateToPoseaction names (camel case vs. snake case).