Fix floating point comparison in JTC#879
Merged
christophfroehlich merged 3 commits intoros-controls:masterfrom Dec 4, 2023
Merged
Fix floating point comparison in JTC#879christophfroehlich merged 3 commits intoros-controls:masterfrom
christophfroehlich merged 3 commits intoros-controls:masterfrom
Conversation
bmagyar
added
backport-iron
backport-humble
destogl
approved these changes
Dec 4, 2023
christophfroehlich
approved these changes
Dec 4, 2023
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
LGTM, only one small fix in the format.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
==========================================
+ Coverage 46.73% 47.33% +0.60%
==========================================
Files 40 40
Lines 3640 3640
Branches 1718 1718
==========================================
+ Hits 1701 1723 +22
+ Misses 749 725 -24
- Partials 1190 1192 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
removed
the
backport-humble
mergify Bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 71b06d0)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 4, 2023
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <[email protected]>
bmagyar
pushed a commit
that referenced
this pull request
Dec 5, 2023
Contributor
Author
|
Thanks for fixing this up and merging! Can this be backported to humble as well? |
Member
|
I included this in #801 to avoid any conflicts on JTC. I hope it get merged soon, if you prefer you can use the branch and build it from source in the meantime (and give feedback/approval to the PR if you tested it successfully). |
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <[email protected]>
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <[email protected]>
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Denis Štogl <[email protected]>
greencookie-afk
pushed a commit
to greencookie-afk/ros2_controllers
that referenced
this pull request
Apr 24, 2026
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going through the MoveIt tutorials and there were instances where motion planning succeeded but execution failed with the error
Changing the comparison to use an epsilon fixed it locally for me.