[JTC] Activate checks for parameter validation#857
Merged
bmagyar merged 4 commits intoros-controls:masterfrom Nov 30, 2023
Merged
[JTC] Activate checks for parameter validation#857bmagyar merged 4 commits intoros-controls:masterfrom
bmagyar merged 4 commits intoros-controls:masterfrom
Conversation
christophfroehlich
added
backport-humble
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
- Coverage 47.22% 47.19% -0.03%
==========================================
Files 40 40
Lines 3636 3636
Branches 1716 1716
==========================================
- Hits 1717 1716 -1
+ Misses 735 734 -1
- Partials 1184 1186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
saikishor
reviewed
Nov 25, 2023
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
Minor comments. The rest looks good to me. 👏
Member
Author
you are right, but the |
bmagyar
approved these changes
Nov 30, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
(cherry picked from commit fcc0847) # Conflicts: # joint_trajectory_controller/test/test_trajectory_controller.cpp # joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
mergify Bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
(cherry picked from commit fcc0847) # Conflicts: # joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
This was referenced Nov 30, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 30, 2023
bmagyar
added a commit
that referenced
this pull request
Dec 1, 2023
* [JTC] Activate checks for parameter validation (#857) (cherry picked from commit fcc0847) # Conflicts: # joint_trajectory_controller/test/test_trajectory_controller_utils.hpp * fix conflict * Fix Mergify/bp/iron/pr 857 (#874) * Revert "fix conflict" This reverts commit c0aaabf. * Fix merge conflict --------- Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Bence Magyar <[email protected]>
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
greencookie-afk
pushed a commit
to greencookie-afk/ros2_controllers
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the temporarily deactivated test for parameter validation.
It checks now if validators are set correctly for generate_parameter_library (GPL checks for parameter itself only; during
on_init()) and if valid combinations are checked by JTC duringon_configure()