[JTC] Remove unused home pose#845
Merged
bmagyar merged 2 commits intoros-controls:masterfrom Nov 19, 2023
Merged
Conversation
christophfroehlich
added
backport-iron
backport-humble
saikishor
approved these changes
Nov 17, 2023
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
LGTM. Thank you so much for cleaning it up.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 45.53% 44.85% -0.69%
==========================================
Files 40 40
Lines 3654 3636 -18
Branches 1724 1716 -8
==========================================
- Hits 1664 1631 -33
- Misses 810 832 +22
+ Partials 1180 1173 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Removing untested code is decreasing coverage, that's not fair 🥲 |
bmagyar
approved these changes
Nov 19, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
(cherry picked from commit 41610fd) # Conflicts: # joint_trajectory_controller/src/joint_trajectory_controller.cpp
mergify Bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
(cherry picked from commit 41610fd)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 19, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 27, 2023
bmagyar
pushed a commit
that referenced
this pull request
Nov 28, 2023
(cherry picked from commit 41610fd) Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 29, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 30, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
greencookie-afk
pushed a commit
to greencookie-afk/ros2_controllers
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #841, see the discussion in the issue.