Skip to content

[JTC] Fix typos, implicit cast, const member functions#748

Merged
bmagyar merged 4 commits intoros-controls:masterfrom
christophfroehlich:jtc_typos
Aug 16, 2023
Merged

[JTC] Fix typos, implicit cast, const member functions#748
bmagyar merged 4 commits intoros-controls:masterfrom
christophfroehlich:jtc_typos

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich commented Aug 16, 2023 •
edited
Loading

Fix typos, implicit cast warnings, and declare const member functions as const

@christophfroehlich christophfroehlich added the backport-humble Triggers PR backport to ROS 2 humble. label Aug 16, 2023
@christophfroehlich @saikishor
Declare const member functions
1552bc9 
Co-authored-by: Sai Kishor Kothakota <[email protected]>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #748 (472a1a0) into master (e7f9962) will decrease coverage by 4.90%.
Report is 355 commits behind head on master.
The diff coverage is 25.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   35.78%   30.88%   -4.90%     
==========================================
  Files         189        7     -182     
  Lines       17570      832   -16738     
  Branches    11592      505   -11087     
==========================================
- Hits         6287      257    -6030     
+ Misses        994      133     -861     
+ Partials    10289      442    -9847
Flag Coverage Δ
unittests 30.88% <25.91%> (-4.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 12.66% <7.81%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 47.13% <46.94%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@christophfroehlich christophfroehlich changed the title [JTC] Fix typos und implicit cast [JTC] Fix typos, implicit cast, const member functions Aug 16, 2023
saikishor
saikishor approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor
Copy link
Copy Markdown
Member

saikishor commented Aug 16, 2023

It is weird that CI says that the changes break ABI. I don't see any ABI breaking changes.

Thanks for the changes

@christophfroehlich
Copy link
Copy Markdown
Member Author

christophfroehlich commented Aug 16, 2023

It is weird that CI says that the changes break ABI. I don't see any ABI breaking changes.

I guess that the const qualifiers change ABI?

has_active_trajectory from #558 has not been released until now, and the other methods are for testing only -> don't see any problem changing this now.

@saikishor
Copy link
Copy Markdown
Member

saikishor commented Aug 16, 2023

I guess that the const qualifiers change ABI?

Ideally it shouldn't, but I might be wrong

Anyway, this is local to the controller and it is not used as a library, so we can go ahead with the PR

bmagyar
bmagyar approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thank you!

@bmagyar bmagyar merged commit 6b73cf5 into ros-controls:master Aug 16, 2023
mergify Bot pushed a commit that referenced this pull request Aug 16, 2023
@christophfroehlich @mergify
[JTC] Fix typos, implicit cast, const member functions (#748)
b17ce5a 
(cherry picked from commit 6b73cf5)

# Conflicts:
#	joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
#	joint_trajectory_controller/src/joint_trajectory_controller.cpp
#	joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
@mergify mergify Bot mentioned this pull request Aug 16, 2023
Closed
@christophfroehlich christophfroehlich deleted the jtc_typos branch August 16, 2023 13:55
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 15, 2023
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (backport ros-…
e39a355 
…controls#748)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 17, 2023
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (backport ros-…
26a7174 
…controls#748)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 27, 2023
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (backport ros-…
7061416 
…controls#748)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (backport ros-…
64541ab 
…controls#748)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 30, 2023
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (backport ros-…
c534a52 
…controls#748)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (backport ros-…
f516ab4 
…controls#748)
bmagyar pushed a commit that referenced this pull request Dec 6, 2023
@christophfroehlich @bmagyar
[JTC] Fix typos, implicit cast, const member functions (backport #748)
b69b6ae
greencookie-afk pushed a commit to greencookie-afk/ros2_controllers that referenced this pull request Apr 24, 2026
@christophfroehlich
[JTC] Fix typos, implicit cast, const member functions (ros-controls#748
2230a9d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

Assignees

No one assigned

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christophfroehlich @codecov-commenter @saikishor @bmagyar