Fix CLI config file loading from directories outside of trellis#458
Merged
swalkinshaw merged 1 commit intomasterfrom Aug 29, 2024
Merged
Fix CLI config file loading from directories outside of trellis#458swalkinshaw merged 1 commit intomasterfrom
trellis#458swalkinshaw merged 1 commit intomasterfrom
Conversation
Fixes a bug where the project CLI config was only loaded if the CLI command was run from within the `trellis` directory. The project CLI config file was being loaded _before_ the project `Path` was set which meant it wasn't found and loaded. Now it's loaded after the `Path` is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the project CLI config (
trellis.cli.yml) was only loaded if the CLI command was run from within thetrellisdirectory.The project CLI config file was being loaded before the project
Pathwas set which meant it wasn't found and loaded. Now it's loaded after thePathis set.cc @MWDelaney thanks!