Improve consistency and usability of Vault commands#388
Merged
swalkinshaw merged 1 commit intomasterfrom Aug 22, 2023
Merged
Conversation
swalkinshaw
force-pushed
the
consistent-vault-commands
branch
2 times, most recently
from
c21c181 to
6b1b03e
Compare
swalkinshaw
force-pushed
the
consistent-vault-commands
branch
from
6b1b03e to
c9c1bf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vaultcommands weren't consistent and had weird quirks. This makes the commands consistent while providing better defaults and improved usability. Changes:-f(--file) replaces the existing--filesflag is now supported on all 4 commands. The old--fileswas a comma separated string while the new-fcan be used multiple times and will autocomplete files-fcannot be combined with a positionENVIRONMENToption on any command since it was confusing and inconsistentvault viewandvault editno longer require an argument. They will default to showing a select input UI to choose from a vault file.vault encryptandvault decryptno longer require an argument. Both will default to all vault files.Closes #356