Skip to content

fix: $webroot_dir phpdoc type #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
retlehs merged 1 commit into from
Sep 19, 2025
Merged

fix: $webroot_dir phpdoc type #781

retlehs merged 1 commit into from
Sep 19, 2025

Conversation

@LucasDemea
Copy link
Contributor

@LucasDemea LucasDemea commented Sep 16, 2025

This fixes the following phpstan error regarding the type of $webroot_dir declared in the phpdoc :

PHPDoc tag @var with type string is not subtype of native type  
         non-falsy-string.                                               
         🪪  varTag.nativeType

retlehs
retlehs approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@retlehs retlehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@retlehs retlehs merged commit 27f147d into roots:master Sep 19, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retlehs retlehs retlehs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LucasDemea @retlehs