Skip to content

Do not leak socket in case of success.#339

Merged
AkihiroSuda merged 1 commit intorootless-containers:masterfrom
jnovy:socketfix
Mar 27, 2024
Merged

Do not leak socket in case of success.#339
AkihiroSuda merged 1 commit intorootless-containers:masterfrom
jnovy:socketfix

Conversation

@jnovy
Copy link
Copy Markdown
Contributor

@jnovy jnovy commented Mar 20, 2024

There seems to be a socket leak in case of success in configure_network() function. This simple patch fixes this.

Copy link
Copy Markdown
Collaborator

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda added this to the v1.2.4 milestone Mar 27, 2024
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit c2f829d into rootless-containers:master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants