fix some FDs leaks#334
Merged
AkihiroSuda merged 6 commits intorootless-containers:masterfrom Feb 6, 2024
Merged
Conversation
Signed-off-by: Giuseppe Scrivano <[email protected]>
it is freed with "free" in different places, so allocate using the stdlib function. Signed-off-by: Giuseppe Scrivano <[email protected]>
it is allocated using g_malloc0 and passed to a list, that is later freed with g_free. Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Collaborator
Author
|
@AkihiroSuda PTAL |
AkihiroSuda
reviewed
Feb 6, 2024
| struct api_ctx *api_ctx_alloc(struct slirp4netns_config *cfg) | ||
| { | ||
| struct api_ctx *ctx = (struct api_ctx *)g_malloc0(sizeof(*ctx)); | ||
| struct api_ctx *ctx = (struct api_ctx *)calloc(1, sizeof(*ctx)); |
Collaborator
Author
There was a problem hiding this comment.
g_malloc0 using malloc internally is just an implementation detail. Since we free ctx with free, we should either change g_malloc() -> malloc(), or free() with g_free().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more information in each commit message.
Found by static analysis.