rootlesskit-docker-proxy: exit without error when port driver does not support v6 (fix Docker 20.10.6 + slirp4netns port driver)#249
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
changed the title
Member
Author
|
cc @thaJeztah |
…t support v6 Fix issue 250 Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Contributor
|
@AkihiroSuda in this case, is it that the driver doesn't support IPv6, or the host? While this (generally) seems ok to do, if it's the latter (host doesn't support IPv6), I'm wondering if the docker daemon / libnetwork failed to detect if IPv6 can be used (and should not have attempted to publish on IPv6 in the first place) |
Member
Author
The driver. The |
Contributor
|
Ah, thanks, so handling of dockerd is correct otherwise (and in the "non-rootless" case)? |
Member
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #250 (regression in Docker 20.10.6)
The error only affects slirp4netns port driver users (non-default), not slirp4netns network driver users.