support forwarding signals#127
Merged
AkihiroSuda merged 1 commit intorootless-containers:masterfrom Mar 15, 2020
Merged
Conversation
Member
Author
Merged
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
Mar 15, 2020
See rootless-containers/rootlesskit#127 RootlessKit changes: rootless-containers/rootlesskit@v0.9.1...v0.9.2 Signed-off-by: Akihiro Suda <[email protected]>
This was referenced Mar 15, 2020
Closed
tianon
reviewed
Mar 17, 2020
| for _, s := range SignalMap { | ||
| handledSigs = append(handledSigs, s) | ||
| } | ||
| signal.Notify(sigc, handledSigs...) |
There was a problem hiding this comment.
Is there a reason this isn't just doing signal.Notify(sigc)? (which should catch all signals without an explicit list)
(Also opencontainers/runc#2257, which I'm guessing you've probably already seen 😄)
Member
Author
There was a problem hiding this comment.
copypasta from moby 😓
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Mar 30, 2020
See rootless-containers/rootlesskit#127 RootlessKit changes: rootless-containers/rootlesskit@v0.9.1...v0.9.2 Signed-off-by: Akihiro Suda <[email protected]> Upstream-commit: f310bd29bd5ab52caa0536c85d564461a70abf16 Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
The implementation is based on https://github.com/docker/cli/blob/ef2f64abbd37edfa148f745fa0013731b5074d1b/cli/command/container/tty.go#L99-L12