stl_makeproject_test: Add dependency on Hist (if available)#810
Merged
hahnjo merged 1 commit intoroot-project:masterfrom Jan 26, 2022
Merged
stl_makeproject_test: Add dependency on Hist (if available)#810hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo merged 1 commit intoroot-project:masterfrom
Conversation
This resolves issues with in-tree builds of roottest where the build system would try to generate the dictionary before Hist is built and then fails because TH1D.h is included, but Hist.pcm not specified as a by-product. Closes root-project/root#9600
|
Starting build on |
Member
Author
In case of an out-of-tree build, we can rely that ROOT has been fully built, so we don't need a dependency. |
pcanal
approved these changes
Jan 25, 2022
Member
|
Oh, OK, I see (I forgot about modules) |
Member
|
Thanks @hahnjo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issues with in-tree builds of roottest where the build system would try to generate the dictionary before Hist is built and then fails because
TH1D.his included, butHist.pcmnot specified as a by-product.Closes root-project/root#9600