Skip to content

[cling] Add test for function with try-catch body#808

Merged
hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo:cling-auto-try
Jan 27, 2022
Merged

[cling] Add test for function with try-catch body#808
hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo:cling-auto-try

Conversation

@hahnjo
Copy link
Copy Markdown
Member

@hahnjo hahnjo commented Jan 25, 2022

See root-project/root#9664 for context.

@hahnjo hahnjo self-assigned this Jan 25, 2022
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@vgvassilev
Copy link
Copy Markdown
Member

Ok, that should do. Normally, for cling-related changes we extend the test suite in cling. That helps the standalone case.

@phsft-bot
Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\roottest-pullrequests-build
See console output.

Failing tests:

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 26, 2022

Ok, that should do. Normally, for cling-related changes we extend the test suite in cling. That helps the standalone case.

I somehow had in my head that it's not enabled in standalone Cling, but there indeed seems to be interpreter/cling/test/Extensions/ImplicitAutoKeyword/. However, all tests in there are XFAIL: * and I think Cling tests are generally not run for ROOT PRs, are they?

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 26, 2022

@bellenot this is the test I mentioned, somehow I don't get the output from the catch block on Windows. Is there a problem with throwing integers on Windows?

@bellenot
Copy link
Copy Markdown
Member

@hahnjo well, not sure how well the exception handling works on Windows. It's still something I have to figure out. I would suggest to disable this test on Windows for the time being, until I manage to fix EH on Win32 and Win64...

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 26, 2022

The failures in roottest/cling/exception are because I don't have #803 in the branch.

@phsft-bot
Copy link
Copy Markdown

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 27, 2022

Now correctly disabled on Windows:

21:19:16            Start  371: roottest-cling-function-trybody_WILL_FAIL
21:19:18   397/1244 Test  #371: roottest-cling-function-trybody_WILL_FAIL .................................................   Passed    2.43 sec

Good to merge, @Axel-Naumann @vgvassilev ?

Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Axel-Naumann
Copy link
Copy Markdown
Member

(FYI and for the future, cling repairs that don't involve ROOT at all often have their test added in interpreter/cling/test, so standalone cling sees these tests, too.)

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 27, 2022

(FYI and for the future, cling repairs that don't involve ROOT at all often have their test added in interpreter/cling/test, so standalone cling sees these tests, too.)

see

Ok, that should do. Normally, for cling-related changes we extend the test suite in cling. That helps the standalone case.

I somehow had in my head that it's not enabled in standalone Cling, but there indeed seems to be interpreter/cling/test/Extensions/ImplicitAutoKeyword/. However, all tests in there are XFAIL: * and I think Cling tests are generally not run for ROOT PRs, are they?

@Axel-Naumann
Copy link
Copy Markdown
Member

Of course you're right, @hahnjo , thanks for correcting me!

@hahnjo hahnjo merged commit e2a390c into root-project:master Jan 27, 2022
@hahnjo hahnjo deleted the cling-auto-try branch January 27, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants