Align pythonization of TDirectory::WriteObject with its C++ counterpart#9990
Merged
vepadulano merged 2 commits intoroot-project:masterfrom Mar 2, 2022
Merged
Conversation
Similarly to what is done in TDirectory::WriteObject. The cppyy pythonization of this method had to rely only on WriteObjectAny since the wrapped C++ type of the object is obfuscated.
|
Starting build on |
etejedor
approved these changes
Mar 1, 2022
Contributor
etejedor
left a comment
etejedor
left a comment
There was a problem hiding this comment.
LGTM thanks! Pity that we can't just use WriteObject and we need the extra conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9989