Fix for name resolution of GDML objects defined in children files.#9908
Merged
agheata merged 1 commit intoroot-project:masterfrom Feb 17, 2022
agheata:root-9744
Merged
Fix for name resolution of GDML objects defined in children files.#9908agheata merged 1 commit intoroot-project:masterfrom agheata:root-9744
agheata merged 1 commit intoroot-project:masterfrom
agheata:root-9744
Conversation
|
Starting build on |
couet
approved these changes
Feb 16, 2022
Member
|
LGTM - I trust you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixes GDML name resolution for positions, rotations, scales, solids and volumes defined in a secondary file.
Changes or fixes:
GDML allows implicit namespacing for objects defined in children files. The current implementation of the ROOT GDML parser is flawed in this respect. Objects are temporarily stored with an appended suffix to their name, but their subsequent search by name ignores the suffix, not finding the ones already defined. The fix corrects this by first searching in the local file namespace, then in the global namespace.
Checklist:
This PR fixes #9744