Skip to content

v626: Extend io customization support: whole obj rule in split obj.#9771

Merged
pcanal merged 9 commits intoroot-project:v6-26-00-patchesfrom
pcanal:v626-issue-8428
Feb 1, 2022
Merged

v626: Extend io customization support: whole obj rule in split obj.#9771
pcanal merged 9 commits intoroot-project:v6-26-00-patchesfrom
pcanal:v626-issue-8428

Conversation

@pcanal
Copy link
Copy Markdown
Member

@pcanal pcanal commented Feb 1, 2022

Backport of #8429

Extend the support for a rule that applies to several data members (and thus currently is applied as the 'object level') to
the case of a split object embedded within a split subobject of an object (previous it worked only for the collection case).

This fixes issue #8428 , see also https://cdcvs.fnal.gov/redmine/issues/25893.

This PR fixes #8428

Extend the support for a rule that applies to several data members (and thus currently is applied as the 'object level') to
the case of a split object embedded within a split subobject of an object (previous it worked only for the collection case).

This fixes issue root-project#8428, see also https://cdcvs.fnal.gov/redmine/issues/25893.
…etion

In the case where the containing object held several sub-object whose
type is a class which has a 'whole object' rule, prior to this commit,
the infrastructure would re-use only one of the incoming object as
input to the rule executions.
…split obj.

Use the full name to make branch name comparisons
The branch ID is not reliable as for the 'later' branch it has not yet been updated from the as-seen-when-writing value to the
current value.
@pcanal pcanal requested a review from Axel-Naumann as a code owner February 1, 2022 14:50
@pcanal pcanal self-assigned this Feb 1, 2022
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@pcanal pcanal changed the title Extend io customization support: whole obj rule in split obj. v626: Extend io customization support: whole obj rule in split obj. Feb 1, 2022
@phsft-bot
Copy link
Copy Markdown

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T16:13:07.525Z] CMake Error at /Applications/CMake.app/Contents/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  • [2022-02-01T16:13:07.525Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@pcanal pcanal merged commit 5847383 into root-project:v6-26-00-patches Feb 1, 2022
@pcanal pcanal deleted the v626-issue-8428 branch February 1, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I/O customization rule not run on split sub-object of a non-collection object.

2 participants