Skip to content

Make sure the temporary file is closed before renaming it. Fixes #9730#9732

Merged
bellenot merged 4 commits intoroot-project:masterfrom
bellenot:fix-9730
Jan 28, 2022
Merged

Make sure the temporary file is closed before renaming it. Fixes #9730#9732
bellenot merged 4 commits intoroot-project:masterfrom
bellenot:fix-9730

Conversation

@bellenot
Copy link
Copy Markdown
Member

@bellenot bellenot commented Jan 27, 2022

As reported on the forun, make sure the temporary file is closed before renaming it. Should fix #9730

@bellenot bellenot requested a review from eguiraud January 27, 2022 12:25
@bellenot bellenot self-assigned this Jan 27, 2022
@bellenot bellenot requested a review from pcanal as a code owner January 27, 2022 12:26
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 27, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

Axel-Naumann
Axel-Naumann reviewed Jan 27, 2022
View reviewed changes
Axel-Naumann
Axel-Naumann approved these changes Jan 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 27, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@bellenot @Axel-Naumann
Update core/dictgen/src/rootcling_impl.cxx
60e3787 
Fix typos. Thanks Axel!

Co-authored-by: Axel Naumann <[email protected]>
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 27, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 27, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 27, 2022

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@bellenot bellenot merged commit dffa6e4 into root-project:master Jan 28, 2022
@bellenot bellenot deleted the fix-9730 branch January 28, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

@eguiraud eguiraud Awaiting requested review from eguiraud

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@bellenot bellenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When working on a Windows partition from Linux, rootcling is not able to rename an output file

3 participants

@bellenot @phsft-bot @Axel-Naumann