Skip to content

[cling] Only add NullPtrChk if enabled (6-26)#9704

Merged
Axel-Naumann merged 2 commits intoroot-project:v6-26-00-patchesfrom
Axel-Naumann:callfunc-no-nullptr-check-part2-v6-26
Jan 27, 2022
Merged

[cling] Only add NullPtrChk if enabled (6-26)#9704
Axel-Naumann merged 2 commits intoroot-project:v6-26-00-patchesfrom
Axel-Naumann:callfunc-no-nullptr-check-part2-v6-26

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann commented Jan 26, 2022

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@Axel-Naumann
[cling] Only add NullPtrChk if enabled.
96ad006 
(cherry picked from commit ef0f14a)
@Axel-Naumann
[TRint] Add --ptrcheck arg to force the cling pointer check:
968290a 
E.g. tests do not have terminals at stdin / stdout, yet some of them want
to test the pointer check facility. Enable that with this new argument.

(cherry picked from commit ca192df)
@Axel-Naumann Axel-Naumann added this to the 6.26/00 milestone Jan 26, 2022
@Axel-Naumann Axel-Naumann self-assigned this Jan 26, 2022
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 26, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann mentioned this pull request Jan 26, 2022
Closed
@Axel-Naumann Axel-Naumann linked an issue Jan 26, 2022 that may be closed by this pull request
Only add cling nullptr checks in TRint #9112
Closed
@Axel-Naumann Axel-Naumann changed the title [cling] Only add NullPtrChk if enabled. [cling] Only add NullPtrChk if enabled (6-26) Jan 26, 2022
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 26, 2022

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 26, 2022

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 26, 2022

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@Axel-Naumann Axel-Naumann mentioned this pull request Jan 26, 2022
Merged
@Axel-Naumann
Copy link
Copy Markdown
Member Author

Axel-Naumann commented Jan 26, 2022

@phsft-bot build

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 26, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann merged commit 60cf11b into root-project:v6-26-00-patches Jan 27, 2022
@Axel-Naumann Axel-Naumann deleted the callfunc-no-nullptr-check-part2-v6-26 branch January 27, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@Axel-Naumann Axel-Naumann

Labels

None yet

Projects

None yet

Milestone

6.26/00

Development

Successfully merging this pull request may close these issues.

Only add cling nullptr checks in TRint

2 participants

@Axel-Naumann @phsft-bot