Skip to content

[cling] Fix AutoSynthesizer on CXXTryStmt#9691

Merged
hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo:cling-auto-try
Jan 26, 2022
Merged

[cling] Fix AutoSynthesizer on CXXTryStmt#9691
hahnjo merged 1 commit intoroot-project:masterfrom
hahnjo:cling-auto-try

Conversation

@hahnjo
Copy link
Copy Markdown
Member

@hahnjo hahnjo commented Jan 25, 2022

This was an oversight in commit 34590ae: After fixing the handler blocks, the code needs to create new CXXCatchStmts to eventually construct the CXXTryStmt.

Fixes #9664

@hahnjo
[cling] Fix AutoSynthesizer on CXXTryStmt
0f644ea 
This was an oversight in commit 34590ae: After fixing the handler
blocks, the code needs to create new CXXCatchStmts to eventually
construct the CXXTryStmt.

Fixes root-project#9664
@hahnjo hahnjo added this to the 6.26/00 milestone Jan 25, 2022
@hahnjo hahnjo self-assigned this Jan 25, 2022
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 25, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@vgvassilev
Copy link
Copy Markdown
Member

vgvassilev commented Jan 25, 2022

Any chance for a test in cling’s teatsuite?

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 25, 2022

Any chance for a test in cling’s teatsuite?

See root-project/roottest#808 (not sure how to link them)

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 25, 2022

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 25, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

Axel-Naumann
Axel-Naumann approved these changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Axel-Naumann
Copy link
Copy Markdown
Member

Axel-Naumann commented Jan 26, 2022

Can you also backport this to v6-26-patches, please?

@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 26, 2022

Can you also backport this to v6-26-patches, please?

Yes will do. How urgent is this? I think the fix is working and we could merge this now, but the test in root-project/roottest#808 fails on Windows...

@Axel-Naumann
Copy link
Copy Markdown
Member

Axel-Naumann commented Jan 26, 2022

Ideally you would backport the fix for root.git now. The change of roottest can stay in master and you can merge that once it's fixed / disabled on windows. Thanks!

@hahnjo hahnjo merged commit 94091b4 into root-project:master Jan 26, 2022
@hahnjo hahnjo deleted the cling-auto-try branch January 26, 2022 13:32
@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jan 26, 2022

Ideally you would backport the fix for root.git now. The change of roottest can stay in master and you can merge that once it's fixed / disabled on windows. Thanks!

Done, also directly pushed to v6-26-00-patches given that no test detected the failure anyhow. I'll wait for Jenkins to complete root-project/roottest#808 before I merge that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

@vgvassilev vgvassilev Awaiting requested review from vgvassilev

Assignees

@hahnjo hahnjo

Labels

in:Cling

Projects

None yet

Milestone

6.26/00

Development

Successfully merging this pull request may close these issues.

[Cling] Interpreter regression 6.24/06 -> 6.25/02

4 participants

@hahnjo @phsft-bot @vgvassilev @Axel-Naumann