TStreamerInfo::New needs to use the CollectionProxy::New by pcanal · Pull Request #9581 · root-project/root

pcanal · 2022-01-14T16:41:54Z

This fixes issue #9543

In the issue #9543, the unusual situation is the combination of:

there is (intentionally) no dictionary for std::map<int,std::vector<int>>
consequently we use an "emulated collection proxy" for that collection
there is (unintentional due to external config) interpreter information/ClassInfo for std::map<int,std::vector<int>>

The crux of the issue #9543 is:

TClass::fSizeof info prefers the information from the CollectionProxy
TStreamerInfo::fSize is set to the value of TClass::fSizeOf
TClass:New prefers the constructor from the interpreter
TStreamerInfo::New was using TClass::New for that case
On the failing platform, the sizeof(std::map<int,std::vector<int>>) is larger than the size of the emulated collection.

Since the I/O and TStreamerInfo uses the TCollection proxy and all of TStreamerInfo needs to prefer the information from the collection proxy (including the 'sizeof'). To fix #9543 the solution is for

TStremearInfo::New to prefer/use TCollectionProxy::New over TClass::New (i.e. the interpreted constructor in this particular case).

This fixes issue root-project#9543 In the issue root-project#9543, the unusual situation is the combination of: * there is (intentionally) no dictionary for `std::map<int,std::vector<int>>` * consequently we use an "emulated collection proxy" for that collection * there is (unintentional due to external config) interpreter information/ClassInfo for `std::map<int,std::vector<int>>` The crux of the issue root-project#9542 is: * TClass::fSizeof info prefers the information from the CollectionProxy * TStreamerInfo::fSize is set to the value of TClass::fSizeOf * TClass:New prefers the constructor from the interpreter * TStreamerInfo::New was using TClass::New for that case * On the failing platform, the `sizeof(std::map<int,std::vector<int>>)` is larger than the size of the emulated collection. Since the I/O and TStreamerInfo uses the TCollection proxy and all of TStreamerInfo needs to prefer the information from the collection proxy (including the 'sizeof'). To fix root-project#9542 the solution is for * TStremearInfo::New to prefer/use TCollectionProxy::New over TClass::New (i.e. the interpreted constructor in this particular case).

phsft-bot · 2022-01-14T16:42:02Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-14T17:20:44Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

phsft-bot · 2022-01-14T17:25:19Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

phsft-bot · 2022-01-14T18:18:14Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-01-14T17:57:28.245Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
[2022-01-14T17:57:28.245Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
[2022-01-14T18:02:43.357Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
[2022-01-14T18:02:43.357Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]

Failing tests:

phsft-bot · 2022-01-14T19:36:01Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 5 more

phsft-bot · 2022-01-14T19:41:53Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

phsft-bot · 2022-01-14T20:23:46Z

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

hahnjo · 2022-01-18T11:34:03Z

@phsft-bot build

phsft-bot · 2022-01-18T11:34:09Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-18T14:04:37Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

pcanal · 2022-01-18T23:28:07Z

@phsft-bot build only on mac11/cxx17

phsft-bot · 2022-01-18T23:28:13Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

pcanal · 2022-01-18T23:45:13Z

@phsft-bot build just on mac11/cxx17

phsft-bot · 2022-01-18T23:45:18Z

Starting build on mac11/cxx17
How to customize builds

phsft-bot · 2022-01-19T07:50:13Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2022-01-19T15:51:24Z

The mac11/cxx17 failures are pre-existing (issues with template instantiations in cling)

pcanal · 2022-01-19T15:52:03Z

Thanks @hahnjo

phsft-bot · 2022-01-19T16:24:01Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-19T16:44:29Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-01-19T16:44:28.965Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

phsft-bot · 2022-01-19T18:42:54Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2022-01-19T18:42:53.921Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

phsft-bot · 2022-01-19T19:18:12Z

Build failed on mac1015/python3.
Running on macitois19.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-01-19T19:18:11.441Z] CMake Error at /Volumes/HDD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

phsft-bot · 2022-01-19T20:03:14Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-01-19T20:03:13.672Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

phsft-bot · 2022-01-19T20:31:12Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-01-19T20:31:11.635Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

phsft-bot · 2022-01-19T21:10:57Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-01-19T21:10:56.503Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

phsft-bot · 2022-01-19T22:35:57Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-01-19T22:35:56.348Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

pcanal requested a review from Axel-Naumann January 14, 2022 16:42

pcanal requested a review from hahnjo January 14, 2022 16:42

hahnjo approved these changes Jan 14, 2022

View reviewed changes

jalopezg-git assigned pcanal Jan 14, 2022

jalopezg-git added affects:master bug in:I/O labels Jan 14, 2022

pcanal merged commit 7bb3494 into root-project:master Jan 19, 2022

pcanal deleted the Issue-9543 branch January 19, 2022 15:52

pcanal modified the milestone: 9543 Jan 19, 2022

pcanal linked an issue Jan 19, 2022 that may be closed by this pull request

roottest-root-treeformula-stl-make crashes during process termination #9543

Closed

Conversation

pcanal commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Jan 14, 2022

Uh oh!

phsft-bot commented Jan 14, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 14, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 14, 2022

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jan 14, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 14, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 14, 2022

Failing tests:

Uh oh!

hahnjo commented Jan 18, 2022

Uh oh!

phsft-bot commented Jan 18, 2022

Uh oh!

phsft-bot commented Jan 18, 2022

Uh oh!

pcanal commented Jan 18, 2022

Uh oh!

phsft-bot commented Jan 18, 2022

Uh oh!

pcanal commented Jan 18, 2022

Uh oh!

phsft-bot commented Jan 18, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Failing tests:

Uh oh!

pcanal commented Jan 19, 2022

Uh oh!

pcanal commented Jan 19, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

phsft-bot commented Jan 19, 2022

Errors:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pcanal commented Jan 14, 2022 •

edited

Loading