Skip to content

Fix TMVA PyTorch tests on Windows. Resolves #9487#9541

Merged
bellenot merged 2 commits intoroot-project:masterfrom
bellenot:fix-9487
Jan 12, 2022
Merged

Fix TMVA PyTorch tests on Windows. Resolves #9487#9541
bellenot merged 2 commits intoroot-project:masterfrom
bellenot:fix-9487

Conversation

@bellenot
Copy link
Copy Markdown
Member

@bellenot bellenot commented Jan 11, 2022

This PR should fix #9487

@bellenot bellenot self-assigned this Jan 11, 2022
@bellenot bellenot requested a review from lmoneta January 11, 2022 14:25
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 11, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 11, 2022

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-01-11T14:27:23.723Z] CMake Error at tmva/pymva/test/CMakeLists.txt:67:
  • [2022-01-11T14:27:24.245Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1136 (message):

lmoneta
lmoneta approved these changes Jan 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Bertrand for fixing this issue !

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 11, 2022

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-01-11T15:03:42.456Z] CMake Error at tmva/pymva/test/CMakeLists.txt:67:
  • [2022-01-11T15:03:42.712Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1136 (message):

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jan 11, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@bellenot bellenot merged commit 3bc44c0 into root-project:master Jan 12, 2022
@bellenot bellenot deleted the fix-9487 branch January 12, 2022 07:04
rahulgrit pushed a commit to rahulgrit/root that referenced this pull request Jan 25, 2022
@bellenot @rahulgrit
Fix TMVA PyTorch tests on Windows. Resolves root-project#9487 (root-p…
88b7a5c 
…roject#9541)

* Fix TMVA PyTorch tests on Windows. Resolves root-project#9487

* Remove extra closing parenthesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmoneta lmoneta lmoneta approved these changes

Assignees

@bellenot bellenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SofieCompileModels_PyTorch.vcxproj fails to compile on pytest version 6.2.5

3 participants

@bellenot @phsft-bot @lmoneta