Skip to content

Advertise change of default units affecting material properties.#9393

Merged
agheata merged 1 commit intoroot-project:masterfrom
agheata:units_warn
Dec 8, 2021
Merged

Advertise change of default units affecting material properties.#9393
agheata merged 1 commit intoroot-project:masterfrom
agheata:units_warn

Conversation

@agheata
Copy link
Copy Markdown
Member

@agheata agheata commented Dec 8, 2021

This Pull request:

Advertises the change of default geometry units affecting several ROOT versions, and how to address this.

Changes or fixes:

User information

Checklist:

  • [] tested changes locally
  • updated the docs (if necessary)

This PR fixes #9383

@agheata agheata requested a review from couet December 8, 2021 10:24
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 8, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@couet
Copy link
Copy Markdown
Member

couet commented Dec 8, 2021

Hi Andrei. It looks ok for me. Note that I did a spell check and found a typo on line 586. It is written "avaoid" instead of "avoid". May be you can add this little fix to this PR ?

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 8, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@agheata
Copy link
Copy Markdown
Member Author

agheata commented Dec 8, 2021

Hi Andrei. It looks ok for me. Note that I did a spell check and found a typo on line 586. It is written "avaoid" instead of "avoid". May be you can add this little fix to this PR ?

Should be fixed now, thanks

@agheata agheata merged commit 264dd16 into root-project:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@couet couet couet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TGeo][Regression] RadLen and IntLen changed by factor of 10 (default unit system)

3 participants

@agheata @phsft-bot @couet