Skip to content

Fix candle plot problem#9363

Merged
linev merged 3 commits intoroot-project:masterfrom
linev:fix_candle2
Dec 2, 2021
Merged

Fix candle plot problem#9363
linev merged 3 commits intoroot-project:masterfrom
linev:fix_candle2

Conversation

@linev
Copy link
Copy Markdown
Member

@linev linev commented Dec 1, 2021

Fixes #9362

linev added 2 commits December 1, 2021 18:45
@linev
[candle] avoid setting horizontal option twice
659c492 
May lead to wrong painting results
@linev
[candle] use lower/upper bin edges with kWhisker15 option
7cfeaad 
In current implementation algorithm always uses center of the first
non-empty bin for left and right limit of interval with 99.9% counts.
In case when the only non-empty bin exists, one gets zero interval
which is absolutely wrong. Also for low statistics (below 1000) such
approximation is very bad. Therefore use low bin edge of the bin for
left limit and upper bin edge for right limit.
@linev linev added this to the 6.26/00 milestone Dec 1, 2021
@linev linev requested a review from couet December 1, 2021 17:57
@linev linev self-assigned this Dec 1, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 1, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 1, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2021-12-01T18:01:19.672Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-12-01T18:01:19.672Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-12-01T18:06:53.324Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-12-01T18:06:53.324Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 1, 2021

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@couet
Copy link
Copy Markdown
Member

couet commented Dec 2, 2021

I guess the candle plot examples are still ok ?

@linev
[candle] fix kMedianNotched drawing of kBox
3d98569 
In case of low statistic fMedianErr can be larger than +-25% interval,
drawn by kBox, making wired output. Check such condition to keep
drawing inside [fBoxDown..fBoxUp] interval
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 2, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 2, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2021-12-02T11:25:24.774Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-12-02T11:25:24.774Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-12-02T11:31:24.613Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-12-02T11:31:24.613Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]

@couet
Copy link
Copy Markdown
Member

couet commented Dec 2, 2021

ping @georgtroska

@linev linev merged commit 479de34 into root-project:master Dec 2, 2021
@linev linev deleted the fix_candle2 branch December 2, 2021 15:33
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Dec 3, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-12-03T16:01:16.085Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1056 (message):

@georgtroska
Copy link
Copy Markdown

georgtroska commented Dec 3, 2021

Fixes #9362

@linev
Hi,
what was the original problem regarding the horizontal candle?

Georg

@linev
Copy link
Copy Markdown
Member Author

linev commented Dec 4, 2021

what was the original problem regarding the horizontal candle?

It is decoding of the options.
If one specify options candley(100000000), kHorizontal will be add twice to fOption, leading to wrong settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@couet couet couet approved these changes

Assignees

@linev linev

Labels

affects:master bug in:Graphics

Projects

None yet

Milestone

6.26/00

Development

Successfully merging this pull request may close these issues.

Candle plot with low statistic histograms makes strange output

4 participants

@linev @phsft-bot @couet @georgtroska