Skip to content

[ntuple] RField: resolve typedefs to the underlying type#9351

Merged
jalopezg-git merged 4 commits intoroot-project:masterfrom
jalopezg-git:ntuple-resolve-typedef
Dec 1, 2021
Merged

[ntuple] RField: resolve typedefs to the underlying type#9351
jalopezg-git merged 4 commits intoroot-project:masterfrom
jalopezg-git:ntuple-resolve-typedef

Conversation

@jalopezg-git
Copy link
Copy Markdown
Contributor

@jalopezg-git jalopezg-git commented Nov 30, 2021

This pull-request modifies the implementation of RField GetNormalizedType() to resolve typedefs via TClassEdit::ResolveTypedef().

Changes or fixes:

  • GetNormalizedType: use TClassEdit::ResolveTypedef() to resolve type aliases.
  • GetNormalizedType: move to a type translation map.

Checklist:

  • tested changes locally

This PR fixes #9202.

@jalopezg-git jalopezg-git self-assigned this Nov 30, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 30, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@jalopezg-git jalopezg-git changed the title [ntuple] Resolve typedefs to the underlying type [ntuple] RField: resolve typedefs to the underlying type Nov 30, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 30, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2021-11-30T13:04:45.823Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-11-30T13:04:45.823Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-11-30T13:09:55.345Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
  • [2021-11-30T13:09:55.345Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 30, 2021

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@jalopezg-git
Copy link
Copy Markdown
Contributor Author

jalopezg-git commented Nov 30, 2021

@phsft-bot build just on mac1015/python3

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 30, 2021

Starting build on mac1015/python3
How to customize builds

pcanal
pcanal reviewed Nov 30, 2021
View reviewed changes
@jalopezg-git jalopezg-git merged commit d52b455 into root-project:master Dec 1, 2021
@jalopezg-git jalopezg-git deleted the ntuple-resolve-typedef branch December 1, 2021 09:27
This was referenced Dec 16, 2021
Closed
Closed
@mxxo mxxo mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner

@eguiraud eguiraud Awaiting requested review from eguiraud

Assignees

@jalopezg-git jalopezg-git

Labels

improvement in:RNTuple

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ntuple] Members of an aliased type do not resolve to the underlying type

3 participants

@jalopezg-git @phsft-bot @pcanal