Added description field to RNTupleDescriptor::PrintInfo output by psairammohan · Pull Request #9313 · root-project/root

psairammohan · 2021-11-19T13:45:53Z

This Pull request:

Added description field to the output of RNTupleDescriptor::PrintInfo by passing ENTupleInfo::kStorageDetails.
Here is an example output in which Vx is description is set to velocity in x direction. Vy description is not set. The result is as follows:

............................................................
  Vx[#0]  --  Int32                            {id:0}
    Description:         velocity in x direction 
    # Elements:          3354
    # Pages:             1
    Avg elements / page: 3354
    Avg page size:       5773 B
    Size on storage:     5773 B
    Compression:         2.32
............................................................
  Vy [#0]  --  Int32                            {id:1}
    # Elements:          3354
    # Pages:             1
    Avg elements / page: 3354
    Avg page size:       3132 B
    Size on storage:     3132 B
    Compression:         4.28
............................................................

Changes or fixes:

Changes RNTupleDescriptor::PrintInfo

Checklist:

tested changes locally
updated the docs (if necessary)

This PR closes #8377

…Details output.

phsft-bot · 2021-11-19T13:45:56Z

Can one of the admins verify this patch?

psairammohan · 2021-11-25T12:21:51Z

Can anyone trigger the build and/or merge the pull request as @jblomer approved the changes. - @couet ,@jblomer ,@eguiraud ...

eguiraud · 2021-11-25T15:09:15Z

@phsft-bot build

phsft-bot · 2021-11-25T15:09:21Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

eguiraud · 2021-11-25T15:10:19Z

Hi @psairammohan ,
I started the build but I think we need the RNTuple devs, @jalopezg-r00t or @jblomer , to merge.

phsft-bot · 2021-11-25T15:10:57Z

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-11-25T15:10:55.867Z] CMake Error at /Applications/CMake.app/Contents/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
[2021-11-25T15:10:56.127Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1128 (message):

phsft-bot · 2021-11-25T15:37:14Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-11-25T15:16:11.970Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
[2021-11-25T15:16:11.970Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
[2021-11-25T15:21:10.132Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]
[2021-11-25T15:21:10.132Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional character detected [-Wbidirectional=]

jalopezg-git · 2021-11-28T20:12:12Z

tree/ntuple/v7/src/RNTupleDescriptorFmt.cxx

         + "  --  " + Detail::RColumnElementBase::GetTypeName(col.fType);
      std::string id = std::string("{id:") + std::to_string(col.fColumnId) + "}";
      output << nameAndType << std::setw(60 - nameAndType.length()) << id << std::endl;
+      if(col.fFieldDescription != "")


This is not a hot path, but this should be slightly better:

Suggested change

if(col.fFieldDescription != "")

if (!col.fFieldDescription.empty())

jalopezg-git

Hi @psairammohan! Thanks for the contribution!
Just a tiny comment. :-)

jalopezg-git · 2021-12-03T11:23:55Z

@psairammohan please, commit the suggested change in order to merge this as soon as possible. :-)

jalopezg-git · 2021-12-04T01:23:40Z

@phsft-bot build

phsft-bot · 2021-12-04T01:23:46Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

jalopezg-git

LGTM.

phsft-bot · 2021-12-04T02:30:20Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.test_import_pandas

phsft-bot · 2021-12-04T06:13:05Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

jalopezg-git · 2021-12-04T18:18:27Z

@phsft-bot build just on windows10/cxx14

phsft-bot · 2021-12-04T18:18:34Z

Starting build on windows10/cxx14
How to customize builds

phsft-bot · 2021-12-04T20:40:31Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

jalopezg-git · 2021-12-05T17:47:22Z

projectroot.tree.tree.test.gtest_tree_tree_test_entrylist_addsublist

projectroot.tree.tree.test.gtest_tree_tree_test_chain_setentrylist

These failures are totally unrelated.

psairammohan and others added 3 commits November 19, 2021 02:23

Added field description to RNTupleDescriptor::PrintInfo with kStorage…

46e2260

…Details output.

Update RNTupleDescriptorFmt.cxx

36b86b5

semicolon for description field

cf8e038

psairammohan requested a review from jblomer as a code owner November 19, 2021 13:45

jblomer approved these changes Nov 22, 2021

View reviewed changes

couet assigned psairammohan Nov 24, 2021

jalopezg-git self-requested a review November 28, 2021 20:10

jalopezg-git added improvement in:RNTuple labels Nov 28, 2021

jalopezg-git reviewed Nov 28, 2021

View reviewed changes

jalopezg-git approved these changes Nov 28, 2021

View reviewed changes

checking if description is empty in better way

3accdd4

psairammohan requested a review from jalopezg-git December 3, 2021 15:32

jalopezg-git approved these changes Dec 4, 2021

View reviewed changes

jalopezg-git merged commit 08ae392 into root-project:master Dec 5, 2021

	if(col.fFieldDescription != "")
	if (!col.fFieldDescription.empty())

Conversation

psairammohan commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This Pull request:

Changes or fixes:

Checklist:

Uh oh!

phsft-bot commented Nov 19, 2021

Uh oh!

psairammohan commented Nov 25, 2021

Uh oh!

eguiraud commented Nov 25, 2021

Uh oh!

phsft-bot commented Nov 25, 2021

Uh oh!

eguiraud commented Nov 25, 2021

Uh oh!

phsft-bot commented Nov 25, 2021

Errors:

Uh oh!

phsft-bot commented Nov 25, 2021

Warnings:

Uh oh!

jalopezg-git Nov 28, 2021

Choose a reason for hiding this comment

Uh oh!

jalopezg-git left a comment

Choose a reason for hiding this comment

Uh oh!

jalopezg-git commented Dec 3, 2021

Uh oh!

jalopezg-git commented Dec 4, 2021

Uh oh!

phsft-bot commented Dec 4, 2021

Uh oh!

jalopezg-git left a comment

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Dec 4, 2021

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2021

Failing tests:

Uh oh!

jalopezg-git commented Dec 4, 2021

Uh oh!

phsft-bot commented Dec 4, 2021

Uh oh!

phsft-bot commented Dec 4, 2021

Failing tests:

Uh oh!

jalopezg-git commented Dec 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

psairammohan commented Nov 19, 2021 •

edited

Loading