[skip-ci] clarify nature of the lockguard macro and difference to std#9305
Merged
Axel-Naumann merged 9 commits intoroot-project:masterfrom Nov 22, 2021
Merged
[skip-ci] clarify nature of the lockguard macro and difference to std#9305Axel-Naumann merged 9 commits intoroot-project:masterfrom
Axel-Naumann merged 9 commits intoroot-project:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Axel-Naumann
requested changes
Nov 17, 2021
Member
Axel-Naumann
left a comment
Axel-Naumann
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is indeed a significant improvement! Could you consider the suggestions I made?
Co-authored-by: Axel Naumann <[email protected]>
Co-authored-by: Axel Naumann <[email protected]>
Co-authored-by: Axel Naumann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Clarifies documentation on R__LOCKGUARD macro.
Checklist:
Fixes #9294