[metacling] Switch default cling optimization for ROOT to -O1.#9301
[metacling] Switch default cling optimization for ROOT to -O1.#9301Axel-Naumann merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
User CPU time, 2nd run of all tests:
stressGraphics generates code that's full of virtual function calls. This used to explode; a factor 4 is still terrible but given that this is on the "awkward" side of our legacy code likely a price we need to pay. |
The question is how many tutorials and code such as stressGraphics.cxx we have, and more importantly how much of the experiments/users use that style of coding/interfaces. |
|
I know the question, but I don't think anyone knows the answer. The code that gets slowed down is vtable-heavy code (at least I think that's the symptom), i.e. "legacy" code. We need to motivate people to migrate to today's code, so that's what we should be optimize for. We are not making legacy code impossible, but we are indeed pessimizing it. I'd be happy :-) to have someone with |
|
@vgvassilev do you object to me merging? I'd want to see this exposed to users earlier rather than later, to hear feedback before we tag v6.26. I have opened an issue #9312 to keep track. |
No objections. What I'd like to understand is how much code regressed. But also, is the performance benefit significant outside of RDF. Both probably require more field testing... I suspect that for many cases we will be okay. There will be a number of regressed cases. What is unclear is how many are going to be the significantly improved cases. I believe for RDF we control the environment and compile even with -O2. |
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #