Skip to content

Fix for TRatioPlot axes sync#9293

Merged
couet merged 4 commits intoroot-project:masterfrom
belmakier:master
Nov 22, 2021
Merged

Fix for TRatioPlot axes sync#9293
couet merged 4 commits intoroot-project:masterfrom
belmakier:master

Conversation

@belmakier
Copy link
Copy Markdown
Contributor

This Pull request:

Changes or fixes:

Fix for TRatioPlot axes sync:

  • Added TPad::RangeAxis() which only emits the RangeAxisChanged() signal
  • Call this before PaintInit() in THistPainter::Paint()
  • This correctly syncs the histogram axes before the upper histogram is drawn

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #9263

@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@couet couet self-assigned this Nov 17, 2021
@couet couet requested review from couet and removed request for Axel-Naumann, lmoneta and pcanal November 18, 2021 09:45
Copy link
Copy Markdown
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have RangeAxisChanged in TPad.

@bellenot
Copy link
Copy Markdown
Member

@phsft-bot build please

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@couet couet merged commit 1bc5743 into root-project:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TRatioPlot axes sync

4 participants