Skip to content

Fix ROOT for musl libc - part 2#9288

Merged
Axel-Naumann merged 8 commits intoroot-project:masterfrom
balejk:musl
Nov 23, 2021
Merged

Fix ROOT for musl libc - part 2#9288
Axel-Naumann merged 8 commits intoroot-project:masterfrom
balejk:musl

Conversation

@balejk
Copy link
Copy Markdown

@balejk balejk commented Nov 13, 2021

Continuation of #9260, closes #9253. Successfully compiles and launches with both musl and glibc, however the affected features were not specifically tested so please make sure to review carefully.

With musl, compilation only succeeds without builtin XRootD and TBB and without SSL support - the former need to be fixed in the respective projects, the latter would probably require a little more effort as the ruserok function used by net/rpdutils/src/rpdutils.cxx is not available in musl - this implies -Dxrootd=OFF -Dimt=OFF -Dssl=OFF cmake options.

@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@Axel-Naumann
Copy link
Copy Markdown
Member

@phsft-bot build!

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11.6/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

Build failed on mac11.6/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@balejk
Copy link
Copy Markdown
Author

balejk commented Nov 18, 2021

@Axel-Naumann Just to make sure: is anything required of me right now or will you review and diagnose the problems yourself when you have the time? If the former, would you please inform me how to get a CERN account which seems to be mandatory in order to access the build logs?

Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pinging me! I believe this is good to go - these failures happened one night, apparently due to a network issue at CERN. I will re-run the test suite, but there's nothing for you to be done here.

Note that we expect to have publicly accessible logs starting next year, i.e. yes, agrees, we see that as a problem, too!

@Axel-Naumann
Copy link
Copy Markdown
Member

@phsft-bot build

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@balejk
Copy link
Copy Markdown
Author

balejk commented Nov 23, 2021

@Axel-Naumann Network issues again?

@Axel-Naumann
Copy link
Copy Markdown
Member

No, Python / macOS install issues this time :-/ This is good to go!

@Axel-Naumann Axel-Naumann merged commit a7ffb81 into root-project:master Nov 23, 2021
@balejk
Copy link
Copy Markdown
Author

balejk commented Nov 23, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ROOT does not compile on musl libc

4 participants