Fix automatic addition of TEfficiency to current directory#9265
Merged
lmoneta merged 1 commit intoroot-project:masterfrom Nov 12, 2021
Merged
Fix automatic addition of TEfficiency to current directory#9265lmoneta merged 1 commit intoroot-project:masterfrom
lmoneta merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on mac1014/python3. |
pcanal
approved these changes
Nov 9, 2021
pcanal
reviewed
Nov 9, 2021
hist/hist/src/TEfficiency.cxx
Outdated
| } | ||
| Build(name,title); | ||
| } | ||
| } |
…al histograms to the current directory use a separate scope to avoid side-effects such as removing addition of TEfficiency to current directory. See issue root-project#9189
lmoneta
force-pushed
the
tefficiency_fix_ctor
branch
from
6a93cd9 to
b80b5ec
Compare
|
Starting build on |
|
Build failed on mac1014/python3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix using TDirectory::TContext in TEfficiency constructor
This PR fixes #9189