Skip to content

[sqliteds] Prevent temporary tables from being written to disk#9262

Merged
jblomer merged 2 commits intoroot-project:masterfrom
jblomer:rdf-fix-sqliteds
Nov 9, 2021
Merged

[sqliteds] Prevent temporary tables from being written to disk#9262
jblomer merged 2 commits intoroot-project:masterfrom
jblomer:rdf-fix-sqliteds

Conversation

@jblomer
Copy link
Copy Markdown
Contributor

@jblomer jblomer commented Nov 9, 2021

This PR fixes #9231

@jblomer jblomer requested a review from eguiraud November 9, 2021 09:56
@jblomer jblomer self-assigned this Nov 9, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 9, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@jblomer jblomer changed the title [sqliteds] Prevent temporary table to be written on disk [sqliteds] Prevent temporary tables from being written to disk Nov 9, 2021
eguiraud
eguiraud approved these changes Nov 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@eguiraud eguiraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I trust you, but maybe can you elaborate a bit in the commit message about what's going on here? 😄

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 9, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@jblomer
Copy link
Copy Markdown
Contributor Author

jblomer commented Nov 9, 2021

Hi, I trust you, but maybe can you elaborate a bit in the commit message about what's going on here? smile

Yep, done in a code comment

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Nov 9, 2021

Build failed on mac1014/python3.
See console output.

@jblomer jblomer merged commit af2cc2d into root-project:master Nov 9, 2021
@jblomer jblomer deleted the rdf-fix-sqliteds branch November 9, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eguiraud eguiraud eguiraud approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jblomer jblomer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error creating SqliteDataFrame

3 participants

@jblomer @phsft-bot @eguiraud