Fix ROOT for musl libc#9260
Conversation
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
Axel-Naumann
left a comment
Axel-Naumann
left a comment
There was a problem hiding this comment.
Fantastic, thank you so much!
|
@Axel-Naumann Actually, this was not meant to be merged yet, I still haven't resolved all the build issues so it's still not possible to successfully compile with musl (glibc should be fine). I imagined you would just review the proposed changes and let me know if there was anything problematic. But if you think these changes were fine, I will open another pull request once I have identified and found a potential solution to all the remaining issues. |
|
Ha sorry :-) It works for our PR builds, it's certainly an improvement, and we're used to working incrementally. I hope I didn't cause too much trouble on your side! So yes, please keep them coming, especially if they are as nice as this one: removing code! |
|
OK :-) |
Prevent potential infinite recursion and simplify some of the code. This fixes the Github issue root-project#13233 and doesn't affect the already closed Jira issue [root-project#9260](https://sft.its.cern.ch/jira/browse/ROOT-9260)
Prevent potential infinite recursion and simplify some of the code. This fixes the Github issue #13233 and doesn't affect the already closed Jira issue [#9260](https://sft.its.cern.ch/jira/browse/ROOT-9260)
Prevent potential infinite recursion and simplify some of the code. This fixes the Github issue root-project#13233 and doesn't affect the already closed Jira issue [root-project#9260](https://sft.its.cern.ch/jira/browse/ROOT-9260)
Prevent potential infinite recursion and simplify some of the code. This fixes the Github issue #13233 and doesn't affect the already closed Jira issue [#9260](https://sft.its.cern.ch/jira/browse/ROOT-9260)
Prevent potential infinite recursion and simplify some of the code. This fixes the Github issue root-project#13233 and doesn't affect the already closed Jira issue [root-project#9260](https://sft.its.cern.ch/jira/browse/ROOT-9260)
5 participants
It is not possible to compile ROOT with musl libc because in several places it relies on glibc and uses non-standard constructs. This PR aims to fix that, at least to such an extent so that compilation against musl does not fail.