[cling] Remove unneed assert() in DynamicLookup.cpp#9245
Merged
jalopezg-git merged 1 commit intoroot-project:masterfrom Nov 4, 2021
Merged
[cling] Remove unneed assert() in DynamicLookup.cpp#9245jalopezg-git merged 1 commit intoroot-project:masterfrom
assert() in DynamicLookup.cpp#9245jalopezg-git merged 1 commit intoroot-project:masterfrom
Conversation
The case of `ExprAddresses == nullptr` seems to be naturally handled in the lines below. Therefore, removing this assertion -as discussed with vvassilev. Closes issue root-project#8389.
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on mac11.0/cxx17. Failing tests: |
Contributor
Author
These failures are (obviously) unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case of
ExprAddresses == nullptrseems to be naturally handled in the lines below this assertion, which suggests that it is okay if the asserted predicate does not hold.Therefore, removing this assertion -as discussed with @vgvassilev in the linked issue- see here.
Changes or fixes:
assert(), as discussed above.Checklist:
This PR fixes #8389.