[http] analyze websocket opcode in civetweb (#9207)#9209
Merged
linev merged 1 commit intoroot-project:masterfrom Oct 29, 2021
Merged
[http] analyze websocket opcode in civetweb (#9207)#9209linev merged 1 commit intoroot-project:masterfrom
linev merged 1 commit intoroot-project:masterfrom
Conversation
In civetweb socket handler check different operation codes Acording to RFC6455, all not-supported codes should be handled as failure. Means application should get close message. Prevent getting close message twice
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
|
|
Build failed on mac11.0/cxx17. Errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In civetweb socket handler check different operation codes
According to RFC6455, all not-supported codes should be handled as
failure. Means application should get close message for the socket.
Prevent getting close message twice
This PR fixes #9207