[ntuple] Discard const/volatile qualifiers in RField type names#9158
Merged
jalopezg-git merged 2 commits intoroot-project:masterfrom Oct 21, 2021
Merged
[ntuple] Discard const/volatile qualifiers in RField type names#9158jalopezg-git merged 2 commits intoroot-project:masterfrom
const/volatile qualifiers in RField type names#9158jalopezg-git merged 2 commits intoroot-project:masterfrom
Conversation
RField does not care about cv-qualifiers. Use `TClassEdit::CleanType()` to discard them in `GetNormalizedType()`.
Add a `const uint8_t` member to a user-defined struct. This member should be written to disk regardless of the `const` qualifier.
|
Starting build on |
pcanal
approved these changes
Oct 21, 2021
|
Build failed on mac11.0/cxx17. Failing tests: |
|
Build failed on ROOT-ubuntu2004/soversion. Failing tests: |
Contributor
Author
This failure is totally unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request changes RField's
GetNormalizedType()in order to discard cv-qualifiers.Changes or fixes:
TClassEdit::CleanType()to discard them inGetNormalizedType(). Removed the now redundantTrim()function.ntuple_typestest to cover the case described in issue [ntuple]const-qualified members of a user-defined struct do not work #9140.Checklist:
This PR fixes #9140.